On Mon, 31 Aug 2026 23:00:06 GMT, John Hendrikx <[email protected]> wrote:

>> modules/javafx.graphics/src/test/java/test/com/sun/prism/sw/SWDrawingContextTest.java
>>  line 89:
>> 
>>> 87:         }
>>> 88:         catch (Exception e) {
>>> 89:             throw new IllegalStateException(e);
>> 
>> illegal state?  is this the right exception for the occasion?
>
> It hardly matters, this is test code. I use `IllegalStateException` for 
> things that can't happen (which is the case here).

good point, but maybe `throw new AssertionError(e);` instead (as in 
BorderTest:588)

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1969#discussion_r3907198942

Reply via email to