On Tue, 1 Sep 2026 16:07:00 GMT, Nir Lisker <[email protected]> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains eight additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'origin/master' into 8373452.dataformat.2
>> - Merge branch 'master' into 8373452.dataformat.2
>> - review comments
>> - Merge branch 'master' into 8373452.dataformat.2
>> - review comments
>> - review comments
>> - nulls
>> - data format
>
> modules/javafx.graphics/src/main/java/javafx/scene/input/DataFormat.java line
> 194:
>
>> 192:
>> 193: for (String id : identifiers) {
>> 194: hash = 31 * hash + id.hashCode();
>
> The hash should be `identifiers.hashCode()` to match the `equals` check.
please elaborate - the current implementation complies with the hashCode/equals
contract (and is effectively unchanged btw).
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2197#discussion_r3908350386
