On Tue, 1 Sep 2026 20:45:43 GMT, Andy Goryachev <[email protected]> wrote:

>> modules/javafx.graphics/src/main/java/javafx/scene/input/DataFormat.java 
>> line 89:
>> 
>>> 87:      * and breaking our drag view implementation.
>>> 88:      */
>>> 89:     private static final DataFormat DRAG_IMAGE_OFFSET = new 
>>> DataFormat("application/x-java-drag-image-offset");
>> 
>> `DRAG_IMAGE` and `DRAG_IMAGE_OFFSET` are unused (and were unused before this 
>> PR). I don't know where they were supposed to be used, maybe there's some 
>> missing wiring somewhere. They could possibly be removed.
>
> these are being used in `c.s.glass.ui.Clipboard` and `glass_dnd.cpp`
> 
> I think we should add a comment (it won't be visible in the API spec)

Definitely needs a comment.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2197#discussion_r3908370458

Reply via email to