On Tue, 1 Sep 2026 22:01:57 GMT, Andy Goryachev <[email protected]> wrote:
>> Fixes broken navigation introduced in >> [JDK-8370902](https://bugs.openjdk.org/browse/JDK-8370902) with non-zero >> paragraph spacing (above, below, line spacing). >> >> Updated the Rich Editor Demo to allow setting paragraph line spacing in >> addition to space above/below (right click -> Paragraph). >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Andy Goryachev has updated the pull request incrementally with one additional > commit since the last revision: > > d.length modules/jfx.incubator.richtext/src/main/java/com/sun/jfx/incubator/scene/control/richtext/RangeInfo.java line 39: > 37: */ > 38: public final class RangeInfo { > 39: /// { miny1, maxy1, miny2, maxy2, ... } The static factories always produce either null or an even array, and the constructor is private, so maybe just clarify here: /// { miny1, maxy1, miny2, maxy2, ... }, always even and non-empty, or null While a comment is not a real assert, as long as this doesn't change, the rest of the checks for invalid indices are indeed not needed. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2280#discussion_r3912439948
