On Thu, 3 Sep 2026 18:46:55 GMT, Andy Goryachev <[email protected]> wrote:

>> Fixes broken navigation introduced in 
>> [JDK-8370902](https://bugs.openjdk.org/browse/JDK-8370902) with non-zero 
>> paragraph spacing (above, below, line spacing).
>> 
>> Updated the Rich Editor Demo to allow setting paragraph line spacing in 
>> addition to space above/below (right click -> Paragraph).
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Andy Goryachev has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   contains

I tested this on Windows and it works well, but because I need to set up my 
Linux VM from scratch (new machine woes...) it'll take an extra while.

Added a minor comment to the test.

modules/jfx.incubator.richtext/src/test/java/test/jfx/incubator/scene/control/richtext/RichTextAreaNavigationTest.java
 line 227:

> 225:         int count = 0;
> 226:         // this loop should exit as soon as it hits the beginning or end 
> of the document,
> 227:         // but let's set a limit, just in case

Would we want to assert we hit the limit without reaching the end?

-------------

PR Review: https://git.openjdk.org/jfx/pull/2280#pullrequestreview-5198445100
PR Review Comment: https://git.openjdk.org/jfx/pull/2280#discussion_r4005816503

Reply via email to