On Wed, 2 Sep 2026 09:00:19 GMT, Jose Pereda <[email protected]> wrote:

>> Andy Goryachev has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   d.length
>
> modules/jfx.incubator.richtext/src/main/java/com/sun/jfx/incubator/scene/control/richtext/RangeInfo.java
>  line 39:
> 
>> 37:  */
>> 38: public final class RangeInfo {
>> 39:     /// { miny1, maxy1, miny2, maxy2, ... }
> 
> The static factories always produce either null or an even array, and the 
> constructor is private, so maybe just clarify here:
> 
> /// { miny1, maxy1, miny2, maxy2, ... }, always even and non-empty, or null
> 
> 
> While a comment is not a real assert, as long as this doesn't change, the 
> rest of the checks for invalid indices are indeed not needed.

I've updated the comment, thanks!

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2280#discussion_r3915713204

Reply via email to