On Mon, 31 Aug 2026 20:39:15 GMT, Andy Goryachev <[email protected]> wrote:

>> Michael Strauß has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   more render scales
>
> modules/javafx.graphics/src/test/java/test/javafx/scene/layout/RegionTest.java
>  line 2339:
> 
>> 2337: 
>> 2338:     @ParameterizedTest
>> 2339:     @ValueSource(doubles = { 1, 1.25, 1.5, 2.5 })
> 
> should we use the same `renderScales` method source in all the parameterized 
> tests?

That would unnecessarily duplicate test runs, as the `renderScales()` method 
source includes anisotropic render scales. However, I've added quarter 
increments from 1.0 to 2.25.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2278#discussion_r3934084526

Reply via email to