On Wed, 9 Sep 2026 17:30:32 GMT, Andy Goryachev <[email protected]> wrote:

>> Ajit Ghaisas has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Remove Node usage
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlTooltipTest.java
>  line 47:
> 
>> 45:     }
>> 46: 
>> 47:     @Test public void controlHasNoTooltipByDefault() {
> 
> this is minor, but maybe we should move `@Test` annotation on its own line, 
> especially since the whole thing shows up as modified in the diff
> 
> (otherwise, lgtm)

I had the same thought actually, but did not comment as it was the same before.
Would be fine for me as well -- while here we could also drop `public` as it is 
not needed as well (since JUnit 5). Also very minor obviously.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2304#discussion_r3971301557

Reply via email to