On Wed, 9 Sep 2026 14:51:05 GMT, Ajit Ghaisas <[email protected]> wrote:

>> This is a minor test cleanup fix.
>> Note : All tests in `ControlTooltipTest` were disabled/ignored since 
>> beginning.
>> 
>> Fix :
>> The test cases used to make an incorrect assumption that adding a `Tooltip` 
>> to a `Control` adds it to `Control`'s children list. The old test cases are 
>> discarded and new unit tests are added to test setting a `Tooltip` on a 
>> `Control`.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Ajit Ghaisas has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Remove Node usage

modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlTooltipTest.java
 line 47:

> 45:     }
> 46: 
> 47:     @Test public void controlHasNoTooltipByDefault() {

this is minor, but maybe we should move `@Test` annotation on its own line, 
especially since the whole thing shows up as modified in the diff

(otherwise, lgtm)

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2304#discussion_r3971257206

Reply via email to