On Mon, 21 Sep 2026 16:49:38 GMT, Kevin Rushforth <[email protected]> wrote:
>> Ziad El Midaoui has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Minor : Trailing whitespaces removed
>
> tests/manual/web/EventListenerLeak.java line 251:
>
>> 249: VBox instructions = new VBox(
>> 250: new Label("""
>> 251: This test is for EventListener memory leak
>> manual testing\s
>
> I realize this was preexisting, but the extra space before "This" seems odd.
> It shows up in the Label (as it did before your change) and makes the
> alignment look off. In fact, the use of an extra space on most, but not all,
> lines is not the best way to do it. This would be OK to fix in the follow-on
> issue if you prefer.
I was planning to convert these tests to use the new ManualTestWindow in a
follow-up to https://github.com/openjdk/jfx/pull/2156 where all these cosmetic
issues can be addressed (in the next test sprint)
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2315#discussion_r4064474104
