On Tue, 22 Sep 2026 15:22:47 GMT, Martin Fox <[email protected]> wrote:

>> tests/manual/dnd/DndTestDragViewRawImage.java line 62:
>> 
>>> 60:                 "The drag image displayed with the cursor (drag view) " 
>>> +
>>> 61:                 "should match the source image");
>>> 62:         label.setWrapText(true);
>> 
>> comment for L61:
>> on my mac 26.6.2 the drag image matches colors and size UNTIL the cursor 
>> goes beyond the test window, when it shrinks to a smaller size.
>> 
>> does it mean the test failed?
>
> That happens when you drag content onto the desktop. The OS is trying to 
> signal that after the drop it will create a file. This happens in all 
> applications.

Yes.

In any case, the purpose of this test is to check that the colors match. It was 
never about the size. On Windows the size isn't the same even while in the 
window (it's scaled by 1/screen_scale).

And even the colors may not be identical due to transparency.

I suggest changing the instructions to say that the colors of image must be 
similar to that of the source image, but that it might be scaled.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2315#discussion_r4073443914

Reply via email to