On Mon, 21 Sep 2026 12:22:26 GMT, Ziad El Midaoui <[email protected]> wrote:
>> Improved the manual test instructions and pass/fail criteria for the >> following tests : >> >> - NotResizableWindowTest >> - DndBasic >> - DndTestDragViewRawImage >> - PrintDialogModalityTest >> - PrintOrientTest >> - StartIconified >> - DragDropFromSwingComponentInSwingNodeTest >> - DragDropOntoJavaFXControlInJFXPanelTest >> - EmojiTest >> - EventListenerLeak >> - InputTypeAcceptAttributeTest >> - GifImageTestApp >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Ziad El Midaoui has updated the pull request incrementally with one > additional commit since the last revision: > > Minor : Trailing whitespaces removed Went through ~ 1/2 of the tests on mac. Most of my comments refer to improving tests rather than making textual changes. In addition, I was planning to migrate the tests to the `ManualTestWindow` once this PR and the `ManualTestWindow` are accepted. Approving since any major changes to the tests are probably out of scope this time. tests/manual/dnd/DndTestDragViewRawImage.java line 62: > 60: "The drag image displayed with the cursor (drag view) " + > 61: "should match the source image"); > 62: label.setWrapText(true); comment for L61: on my mac 26.6.2 the drag image matches colors and size UNTIL the cursor goes beyond the test window, when it shrinks to a smaller size. does it mean the test failed? tests/manual/stage/StartIconified.java line 47: > 45: 1. The "Iconified Window Test" must initially appear only > on the > 46: operating-system taskbar or Dock. > 47: 2. It must not appear normally on the screen before > becoming iconified, even briefly. If it does, the test fails. on my mac, the app starts with the second window appearing on screen then quickly scurrying into the dock, so it obviously fail the test. a suggestion: to make it easier for the operator, change the background of the initially iconified window to red and make it larger. ------------- Marked as reviewed by angorya (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/2315#pullrequestreview-5270129440 PR Review Comment: https://git.openjdk.org/jfx/pull/2315#discussion_r4065060638 PR Review Comment: https://git.openjdk.org/jfx/pull/2315#discussion_r4065255965
