On Fri, 18 Sep 2026 18:55:54 GMT, Andy Goryachev <[email protected]> wrote:
>> Marius Hanl has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 10 commits: >> >> - Merge branch 'master' of https://github.com/openjdk/jfx into >> 8388277-REDO]-Looked-up-color-fails-for--fx-background-color-in-JavaFX-CSS-file >> - fix >> - test >> - idea how to fix that issue >> - failing test >> - Fix another broken case >> - change the way we process a stale CssStyleHelper >> - Merge branch 'master' of https://github.com/openjdk/jfx into >> 8388277-REDO]-Looked-up-color-fails-for--fx-background-color-in-JavaFX-CSS-file >> - Merge branch 'master' of https://github.com/openjdk/jfx into >> 8388277-REDO]-Looked-up-color-fails-for--fx-background-color-in-JavaFX-CSS-file >> >> # Conflicts: >> # >> modules/javafx.graphics/src/test/java/test/javafx/scene/CssStyleHelperTest.java >> - 8388277: [REDO] Looked-up color fails for -fx-background-color in JavaFX >> CSS file > > modules/javafx.graphics/src/main/java/javafx/scene/CssStyleHelper.java line > 417: > >> 415: int startIndex) { >> 416: int ctr = 0; >> 417: int[] smapIds = new int[path.size() - startIndex]; > > we still seem to have quadratic allocation: each stale ancestor allocates a > `triggerStates` array in L154, and each changed helper allocates and scans > another suffix in its cache key. > > the existing test tracks neither allocations nor scans. Created: https://github.com/openjdk/jfx/pull/2333 which we should check and merge first. This will make this PR much easier and also solves your point. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2225#discussion_r4132008565
