On Mon, 5 Oct 2026 22:02:50 GMT, Andy Goryachev <[email protected]> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add implNote about known snapshot issue > > modules/javafx.graphics/src/main/native-prism-sw/JDirectBufferSurface.c line > 140: > >> 138: } >> 139: >> 140: void* data = (*env)->GetDirectBufferAddress(env, >> surface->dataHandle); > > Will this fail when byte order of the direct buffer differs from the system > byte order? It wouldn't fail, but it would draw something unexpected. I've added checks to ensure the byte order matches the platform so you get an exception when calling `WritableImage::getDrawingContext`. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1969#discussion_r4216152075
