On Mon, 28 Sep 2026 12:26:39 GMT, Kevin Rushforth <[email protected]> wrote:
>> It seems like long ago there were tiny rendering differences encountered >> between the sw and hardware renderer when rendering rounded edges. Instead >> of fixing the root cause, a workaround was added to just render the affected >> edges using a manual sw renderer approach. It seems like everyong forgot, >> and this workaround is still here. As a result, any region with uniform >> corner radius 0 < r <= 4 is rendered using a software renderering approach >> right now. >> >> Maybe the issue has been fixed somehow, the linked issue is very unspecific. >> Even if not, and there are differences between the renderers, they don't >> warrant this performance slowdown. I can't see a difference so far with this >> workaround disabled. >> >> You can see this case being logged when being run with >> `-Djavafx.pulseLogger=true`. According to the counters at the end of a >> render pass, around 10% of nodes were rendered using this ineffecient >> approach in our application. >> >> This case still happens for non-uniform corner radius values, but that is >> somewhat expected. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > This will need careful examination of rendered regions to ensure that we > don't have a noticeable visual regression. Reviewers: @kevinrushforth @lukostyra Others are welcome to look, too. @beldenfox wrote: > But does it matter? It only makes a visual difference on low-resolution > screens and what that means today is very different from when the original > bug was filed. I had to jump through some hoops to get such a small corner on > Windows. @crschnick wrote: > You wouldn't really see a difference in normal use ... without a lot of zoom. > ... > As long as no users can make out weirdly shaped corners from afar, it's good > enough. I agree that both of these statements. It doesn't matter that it matches SW, it matters if it looks good. It might be that with today's monitors, it doesn't matter as much as it once did. ------------- PR Comment: https://git.openjdk.org/jfx/pull/2329#issuecomment-5901116532
