On Fri, 9 Oct 2026 09:15:18 GMT, Johan Vos <[email protected]> wrote: >> Marius Hanl has updated the pull request incrementally with one additional >> commit since the last revision: >> >> revert whitespace change > > modules/javafx.graphics/src/android/native/VMLauncher.c line 60: > >> 58: __android_log_print(3,"JVM", "JNI_OnLoad calling GetEnv()"); >> 59: JNIEnv* env = NULL; >> 60: (*vm)->GetEnv(vm, (void**) &env, JNI_VERSION_1_6); > > This code is currently unused. Iirc, its intention is to start an embedded > JVM, instead of using the Android Java runtime. In that case, it is very > unlikely that anyone wants to build and embed a JVM that doesn't have > JNI_VERSION_1_6, so I don't see problems with this here.
Not sure I understand. Does that mean we should update the Android code to `JNI_VERSION_1_8` as well (from `1_6`)? That is the following classes: - `VMLauncher.c` - `activity.c` - `android_webview.c` - `native_webview.c` ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2175#discussion_r4231158456
