On Fri, 9 Oct 2026 16:03:01 GMT, Johan Vos <[email protected]> wrote:

>> Not sure I understand. Does that mean we should update the Android code to 
>> `JNI_VERSION_1_8` as well (from `1_6`)?
>> 
>> That is the following classes:
>> - `VMLauncher.c`
>> - `activity.c`
>> - `android_webview.c`
>> - `native_webview.c`
>
> Correcting myself: the JNI_OnLoad will be called (if this code was used) from 
> the Android VM, which is limited to 1_6. Hence, we should indeed stick to 1_6.
> 
> As a small remark, the commit message that moved the version from 1_8 to 1_6 
> is "revert android", but this is strictly spoken not a revert (as that would 
> then lower again to 1_4).
> But I don't see a problem with this.

ah yes, as you also said:
I think there should not be any problem with version 1_6, hence I at least 
updated it to that on Android, was there already -- just one class missing.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2175#discussion_r4233283698

Reply via email to