On Fri, 9 Oct 2026 14:24:40 GMT, Marius Hanl <[email protected]> wrote:
>> modules/javafx.graphics/src/android/native/VMLauncher.c line 60: >> >>> 58: __android_log_print(3,"JVM", "JNI_OnLoad calling GetEnv()"); >>> 59: JNIEnv* env = NULL; >>> 60: (*vm)->GetEnv(vm, (void**) &env, JNI_VERSION_1_6); >> >> This code is currently unused. Iirc, its intention is to start an embedded >> JVM, instead of using the Android Java runtime. In that case, it is very >> unlikely that anyone wants to build and embed a JVM that doesn't have >> JNI_VERSION_1_6, so I don't see problems with this here. > > Not sure I understand. Does that mean we should update the Android code to > `JNI_VERSION_1_8` as well (from `1_6`)? > > That is the following classes: > - `VMLauncher.c` > - `activity.c` > - `android_webview.c` > - `native_webview.c` Correcting myself: the JNI_OnLoad will be called (if this code was used) from the Android VM, which is limited to 1_6. Hence, we should indeed stick to 1_6. As a small remark, the commit message that moved the version from 1_8 to 1_6 is "revert android", but this is strictly spoken not a revert (as that would then lower again to 1_4). But I don't see a problem with this. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2175#discussion_r4232082185
