On Fri, 9 Oct 2026 23:53:37 GMT, Kevin Rushforth <[email protected]> wrote:
>> It was a bug discovered during the image import development. I will update >> the `Marker` doc, I think it's ok to include this change in this PR, since >> it's an incubator. > > This change might be OK given that it is intentional and you are documenting > it. Are there cases where a change listener might want to read the new > position? ChangeListeners handle this by passing in the old value, but I > realize this isn't the same case. If you've thought this through, and this is > the semantic behavior you want, then this is fine. > > It does highlight an implementation concern: if any listener throws an > Exception, the marker position will not be updated. This means that an > application bug or other problem in a listener could lead to stale markers, > which I don't think is desirable. > > A preexisting problem is that an exception in one listener will prevent > subsequent listeners from running. > > Both of these issues could be handled in a follow-up. this is another good point: what should be done if a listener throws a RuntimeException? An Exception? An Error? Should the caller just eat any Throwable silently? Log a stack trace? ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2224#discussion_r4251218212
