On Fri, 9 Oct 2026 23:19:53 GMT, Kevin Rushforth <[email protected]> wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> cleanup
>
> modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/Marker.java
> line 38:
>
>> 36: * <p>
>> 37: * The marker position is updated after the model listeners receive their
>> 38: * {@code ContentChange} events.
>
> This seems an odd place to put such a comment. A marker is a data object.
>
> A better place might be in the model when describing the listeners, maybe in
> `StyledTextModel.Listener.onContentChange()`. There you would say something
> like:
>
> "For a content change, marker positions are updated after all listeners
> return. If a listener reads a marker, it will be its position from before the
> change".
I see that you added a comment to StyledTextModel.Listener.onContentChange().
Good.
I recommend to revert the change in _this_ file, since it is out of place.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2224#discussion_r4260703552
