On Mon, 5 Oct 2026 17:04:58 GMT, Andy Goryachev <[email protected]> wrote:
>> Enables importing of images from the clipboard into the RichTextModel by >> adding a data format handler for the DataFormat.IMAGE mime type. >> >> This change includes new utility added by >> [JDK-8390345](https://bugs.openjdk.org/browse/JDK-8390345). >> >> Note: the banana slug image is a public domain added with author's >> permission [0]. >> >> ## References >> >> [0] https://en.wikipedia.org/wiki/Banana_slug >> >> >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Andy Goryachev has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 14 commits: > > - Merge branch 'master' into 8388276.import.images > - Merge branch 'master' into 8388276.import.images > - spelling > - Merge branch 'master' into 8388276.import.images > - copied from swing fx utils > - Merge branch 'master' into 8388276.import.images > - images > - lossless > - Merge branch 'master' into 8388276.import.images > - whitespace > - ... and 4 more: https://git.openjdk.org/jfx/compare/eab83a4b...b4c734c2 I left one comment on the test that needs to be addressed. In addition to not using Robot, tests in the various modules should not depend on the systemTests project. tests/system/src/test/java/test/jfx/incubator/scene/control/richtext/TestImageFormatHandler.java line 61: > 59: > 60: // Tests ImageFormatHandler > 61: public class TestImageFormatHandler extends RobotTestBase { You cannot use Robot for tests in this module. Either move this to system tests, somewhere under test.robot, or rework the test to not need robot. ------------- PR Review: https://git.openjdk.org/jfx/pull/2224#pullrequestreview-5458410403 PR Review Comment: https://git.openjdk.org/jfx/pull/2224#discussion_r4220413643
