On Thu, 15 Oct 2026 12:30:43 GMT, Florian Kirmaier <[email protected]> wrote:
>> Follow-up to JDK-8092379: since then a gap is only rendered before a >> row/column in which a child starts, but two places still assumed a gap >> between every row/column. >> >> adjustRowHeights / adjustColumnWidths reserved a gap before every row/column >> before distributing the percentages. They now reserve only the rendered gaps. >> >> CompositeSize.getProportionalMinOrMaxSize divided the size of a spanning >> child by the number of rows/columns without subtracting the gaps inside the >> span. It now subtracts them. >> >> Each fix is covered by tests that fail before and pass after the change. >> A test application can be found in the ticket. >> >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Florian Kirmaier has updated the pull request incrementally with one > additional commit since the last revision: > > JDK-8392158 > Don't round row/column sizes to whole pixels when snapToPixel is off. modules/javafx.graphics/src/main/java/javafx/scene/layout/GridPane.java line 2314: > 2312: final double change = Math.abs(limit) <= > Math.abs(portion)? limit : portion; > 2313: widths.setSize(index, isSnapToPixel() ? > ScaledMath.rint(widths.getSize(index) + change, getSnapScaleX(this)) : > widths.getSize(index) + change); > 2314: available = isSnapToPixel() ? Math.rint((available > - change) / pixelSize) * pixelSize : available - change; same problem as with heights ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2312#discussion_r4286411016
