> Follow-up to JDK-8092379: since then a gap is only rendered before a 
> row/column in which a child starts, but two places still assumed a gap 
> between every row/column.
> 
> adjustRowHeights / adjustColumnWidths reserved a gap before every row/column 
> before distributing the percentages. They now reserve only the rendered gaps.
> 
> CompositeSize.getProportionalMinOrMaxSize divided the size of a spanning 
> child by the number of rows/columns without subtracting the gaps inside the 
> span. It now subtracts them.
> 
> Each fix is covered by tests that fail before and pass after the change.
> A test application can be found in the ticket.
> 
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Florian Kirmaier has updated the pull request incrementally with one additional 
commit since the last revision:

  JDK-8392158
  split percentage rows/columns in whole pixels.

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/2312/files
  - new: https://git.openjdk.org/jfx/pull/2312/files/f5a1194a..7131ac08

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=2312&range=07
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=2312&range=06-07

  Stats: 36 lines in 2 files changed: 10 ins; 0 del; 26 mod
  Patch: https://git.openjdk.org/jfx/pull/2312.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/2312/head:pull/2312

PR: https://git.openjdk.org/jfx/pull/2312

Reply via email to