On Thu, 22 Oct 2026 13:20:08 GMT, Florian Kirmaier <[email protected]> wrote:
>> Follow-up to JDK-8092379: since then a gap is only rendered before a >> row/column in which a child starts, but two places still assumed a gap >> between every row/column. >> >> adjustRowHeights / adjustColumnWidths reserved a gap before every row/column >> before distributing the percentages. They now reserve only the rendered gaps. >> >> CompositeSize.getProportionalMinOrMaxSize divided the size of a spanning >> child by the number of rows/columns without subtracting the gaps inside the >> span. It now subtracts them. >> >> Each fix is covered by tests that fail before and pass after the change. >> A test application can be found in the ticket. >> >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Florian Kirmaier has updated the pull request incrementally with one > additional commit since the last revision: > > JDK-8392158 > Floor the last-row in multi-span portion to whole device pixels I've added a lot new tests - and some are now also parameterized. @andy-goryachev-oracle Do you see more cases i should i look at? (I would prefer to limit the scope of the PR if possible) ------------- PR Comment: https://git.openjdk.org/jfx/pull/2312#issuecomment-6342602521
