On Thu, 15 Oct 2026 17:38:42 GMT, Kevin Rushforth <[email protected]> wrote:

>> Andy Goryachev has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   whitespace
>
> modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/Marker.java
>  line 69:
> 
>> 67:      * <p>
>> 68:      * The value of this property gets updated after the model listeners 
>> receive their
>> 69:      * {@code ContentChange} events.
> 
> Suggestion:
> 
> 
> 
> To clarify my earlier comment, this documentation doesn't belong anywhere in 
> this file. Marker is a data object. A specification about one particular 
> client's (`Listener.onContentChange()`, in this case) use of that data object 
> belongs at the use site and not here. Since you already added a note there, 
> nothing is needed here.

will revert.  the only reason I added this to Marker is because it contains 
property which gets updated, so I thought it might be helpful.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2224#discussion_r4286442769

Reply via email to