On Mon, 12 Oct 2026 18:55:29 GMT, Andy Goryachev <[email protected]> wrote:

>> Enables importing of images from the clipboard into the RichTextModel by 
>> adding a data format handler for the DataFormat.IMAGE mime type.
>> 
>> This change includes new utility added by 
>> [JDK-8390345](https://bugs.openjdk.org/browse/JDK-8390345).
>> 
>> Note: the banana slug image is a public domain added with author's 
>> permission [0].
>> 
>> ## References
>> 
>> [0] https://en.wikipedia.org/wiki/Banana_slug
>> 
>> 
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Andy Goryachev has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   clarification

I left one inline doc comment and an inline comment about the listener 
exception handling.

Additionally, there is a regression in the reworked `insertSegment`: it can 
incorrectly reorder styled text by merging a split segment such that the 
earlier segment is merged into the following one leaving the one in the middle 
before the beginning:

For example, if `abcdef` is styled such that `ef` and then `ab` is set to bold, 
it will incorrectly merge `ab` and `ef` leaving you with `cdabef`.

-------------

PR Review: https://git.openjdk.org/jfx/pull/2224#pullrequestreview-5506067561

Reply via email to