On 7/9/13 12:03 AM, Ronald Roskens wrote:
> There were a lot of left over logging statements that we didn't get
> around to parameterizing during devjam 2013. I've just committed a
> big update to master with pretty much all logging statements now
> using {} parameters with arguments.Awesome! > Some ideas to follow up on: > > 1. There are log statements that get their message from a > StringBuilder object. Is this needed anymore when using slf4j > parameterized statements? I would think no, might as well parameterize instead. That said, it's probably a matter of diminishing returns at this point. > 2. I noticed a few places in Vacuumd.java where the log message had > the prefix at the start of it. That's not really needed with the new > prefixing Matt & Eric did. Agreed. > 3. There were statements that had newline & tab characters in their > messages. Should the logger calls be separated out into multiple > calls? Probably, yeah, or maybe rethink whether it's necessary to put that much info in a log. > 4. instrumentation log reader - this should probably be tested to > verify that it still works. Good idea. > 5. fix up tools under opennms-tools/ that aren't built normally. Yeah, I noticed we hadn't fixed that yet. Shouldn't be too much that needs cleanup though. -- Benjamin Reed The OpenNMS Group http://www.opennms.org/
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________ Please read the OpenNMS Mailing List FAQ: http://www.opennms.org/index.php/Mailing_List_FAQ opennms-devel mailing list To *unsubscribe* or change your subscription options, see the bottom of this page: https://lists.sourceforge.net/lists/listinfo/opennms-devel
