There were a lot of left over logging statements that we didn't get around to
parameterizing during devjam 2013. I've just committed a big update to master
with pretty much all logging statements now using {} parameters with arguments.
I have been using the command [ git grep -nP
'^\s*LOG\.(trace|debug|info|warn|error)\(.*\+.*\)\;\s*$' ] to check for
statements that had + signs. There are a few left, but they don't use the + to
concatenate strings together for the message.
Some ideas to follow up on:
1. There are log statements that get their message from a StringBuilder object.
Is this needed anymore when using slf4j parameterized statements?
2. I noticed a few places in Vacuumd.java where the log message had the prefix
at the start of it. That's not really needed with the new prefixing Matt & Eric
did.
3. There were statements that had newline & tab characters in their messages.
Should the logger calls be separated out into multiple calls?
4. instrumentation log reader - this should probably be tested to verify that
it still works.
5. fix up tools under opennms-tools/ that aren't built normally.
This was a fun project to work on with Matt, Eric and Joe during dev-jam.
Ron
------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
Please read the OpenNMS Mailing List FAQ:
http://www.opennms.org/index.php/Mailing_List_FAQ
opennms-devel mailing list
To *unsubscribe* or change your subscription options, see the bottom of this
page:
https://lists.sourceforge.net/lists/listinfo/opennms-devel
