Hi Hendrik, I somehow managed to totally miss your win32 patches. I had a look at your patchset from 2007-01-26 now.
They look really clean and seem to have minimal impact (easy review). Moving the BT compatibiliy stuff from some source files to a seperate header is a nice and a much needed clean up. Inserting that LIB_SYMBOL macro seems intrusive but is clean and simple. In lib/obex.c why do you write +#if HAVE_BLUETOOTH +#define WSA_VER_MAJOR 2 +#define WSA_VER_MINOR 2 +#else +#define WSA_VER_MAJOR 2 +#define WSA_VER_MINOR 0 +#endif Your patch set isn't adding more win32 special cases (in fact it removes some ifdef _WIN32 hacks) and also trims the BT ifdefs to a minimum, nice. This patch set is rather big nevertheless and I think every single line should be reviewed. I can take on the simpler cases in the first few patches. The glib changes should be review by Johan and the AM/AC changes need very thorough checking. I'm not much help there I always get lost with m4 code. Let Marcel have another look and if there are no objections I'd like to enable your CVS access so we can discuss the patches in details and you can apply them. ps. Do you like to open a ticket and post all patches there? The diff highlighting is very nice... http://dev.zuckschwerdt.org/openobex/newticket regards, Christian Hendrik Sattler schrieb: >> - Tcp/Ip: native winsock2, works >> > WinXP: no dual stack and thus IPv6-only. > Vista: has dual-stack but is IPv6-only by default [...] IPv6 is useable but not IPv4? Bad. Is your small AF_INET patch all that is need (for the client)? As Marcel seems busy and it's straight forward and I'll apply it right now. > Please see my patches I posted previously. One posting also contains > fine-grained install instructions! > > >> (1) make may fail trying to create a symlink, use "ln -s . include/openobex". >> > No, this will not work on WinXP, e.g. when using MSys. > My patches also fix this by copying instead of linking. > Best solution would be to move the files in SVN to an openobex subdir instead > of fuzzing around on > every run: > mkdir openobex > cp *.h openobex/ > and delete parts of the Makefile. > > This is Marcel's call. I can't tell if the flat include dir is needed. ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ Openobex-users mailing list [email protected] http://lists.sourceforge.net/lists/listinfo/openobex-users
