This is an automated email from Gerrit.

Salvador Arroyo (sarroyof...@yahoo.es) just uploaded a new patch set to Gerrit, 
which you can find at http://openocd.zylin.com/527

-- gerrit

commit 99977d7d8f170d8cd1166a455446f5bf81cb56fb
Author: Salvador <sarroyof...@yahoo.es>
Date:   Sat Mar 17 09:25:23 2012 +0100

    Bug in src/target/mips32_pracc.c
    
    The bug shows up with the command "mdw addres count" and only if count>1024 
(count>0x400).
    The first 1024 values shows as expected, but the rest of the values  are 
wrong.
    Name of variable  bytesread" is changed to "wordsread" to reflect what 
really does.
    
    Change-Id: Iad79393e72da2637551c5ae6e829e3873605c520
    Signed-off-by: Salvador <sarroyof...@yahoo.es>

diff --git a/src/target/mips32_pracc.c b/src/target/mips32_pracc.c
index 267a4ff..0cada4f 100644
--- a/src/target/mips32_pracc.c
+++ b/src/target/mips32_pracc.c
@@ -343,10 +343,10 @@ static int mips32_pracc_read_mem32(struct mips_ejtag 
*ejtag_info, uint32_t addr,
 
        int retval = ERROR_OK;
        int blocksize;
-       int bytesread;
+       int wordsread;
        uint32_t param_in[2];
 
-       bytesread = 0;
+       wordsread = 0;
 
        while (count > 0) {
                blocksize = count;
@@ -357,13 +357,13 @@ static int mips32_pracc_read_mem32(struct mips_ejtag 
*ejtag_info, uint32_t addr,
                param_in[1] = blocksize;
 
                retval = mips32_pracc_exec(ejtag_info, ARRAY_SIZE(code), code,
-                               ARRAY_SIZE(param_in), param_in, blocksize, 
&buf[bytesread], 1);
+                               ARRAY_SIZE(param_in), param_in, blocksize, 
&buf[wordsread], 1);
                if (retval != ERROR_OK)
                        return retval;
 
                count -= blocksize;
-               addr += blocksize;
-               bytesread += blocksize;
+               addr += blocksize*sizeof(uint32_t);
+               wordsread += blocksize;
        }
 
        return retval;

-- 

------------------------------------------------------------------------------
This SF email is sponsosred by:
Try Windows Azure free for 90 days Click Here 
http://p.sf.net/sfu/sfd2d-msazure
_______________________________________________
OpenOCD-devel mailing list
OpenOCD-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openocd-devel

Reply via email to