On Friday 30 of October 2015 10:41:59 Uwe Bonnes wrote: > >>>>> "Freddie" == Freddie Chopin <[email protected]> writes: > Freddie> On Thursday 29 of October 2015 14:55:12 Uwe Bonnes wrote: > >> The relevant patch is > >> > >> Cortex-M: Detect Flash Patch Revision and implement Rev. 2 handling. > >> > >> http://openocd.zylin.com/#/c/2868/ > >> > >> It is hanging in the patch queue with so many other patches... > > Freddie> We can merge it right away (; > > --verbose please > > What is the policy behind letting pending patches pile up. E.g. #2336 has > been approved sind February, but was not applied. Probably it is also work > that Matthias redid with his series of patches.
At the beginning please let me state, that I'm not an active maintainer - I probably merged some things recently, but this cannot be compared with the work of other maintainers. There's no policy, at least I'm not aware of any... I probably still have permissions to merge patches from gerrit, but I'm a little bit afraid that I could merge something that would break other things... With software like OpenOCD it is not possible to verify every change "in reality" - no person has all the hardware or all the setups needed to do that. Additionally no one has time needed to study the technical docs to verify that the change is correct. That's why I think (this is a personal opinion) a test report is worth much more than a code review. I've looked at the 2868 change - at the actual diff - but I cannot tell whether the code is correct or not. I could merge it right away, but I'm not entirely confident to do it... As for the 2336 change - from what I see it has been approved in February and merged on 9th of March... Maybe you had some other change in you mind? Regards, FCh ------------------------------------------------------------------------------ _______________________________________________ OpenOCD-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openocd-devel
