>>>>> "Andreas" == Andreas Fritiofson <[email protected]> writes:
Andreas> On Fri, Oct 30, 2015 at 10:41 AM, Uwe Bonnes <
Andreas> [email protected]> wrote:
Andreas> What is the policy behind letting pending patches pile up.
Andreas> It's not an active decision... I.e. *not* letting them pile up
Andreas> requires work which, apparently, nobody has performed.
Andreas> Someone tell me which patches are *truly* ready to merge and I
Andreas> will click the button. The clicking is not the hard part.
Isn't the "hook" in the "CR" column what is supposed to point to the patches
that are ready to merge?
Otherwise there are two different regions where patches touch openocd:
- central functionality everybody needs
- device/board/adapter specific things that maybe only few people have.
The first category needs stringent code review, I agree.
But for the second category I find using gerrit counterproductive!
Few people have the parts and even fewer people use openocd already, have
the device, follow gerrit closely enough to notice the patch and are
able/willing to review. So no review and testing happens, and the patch
bitrots in gerrit.
And new owners of these parts will maybe try out openocd to use the part, but
as support is not in HEAD, they will quickly turn away. Even a semi-working
patch for their part would maybe trigger them to report the problem, giving
a chance for improvement of the patch.
Otherwise gerrit also hides the history of a patch. What did happen between
the first appearance of the patch and final application will not get part of
the git log. Gerrit even offers nothing like a "git log" while the
patch is worked on. This is a substantial shortcoming of gerrit
i.m.h.o. Correct me if I didn't notice some feature.
In short: Patches like e.g 3011: "niietcm4: support for NIIET's Cortex-M4
microcontrollers" should get applied after the two week grace period
mentioned in http://openocd.org/doc/doxygen/html/patchguide.html even with no
review if nobody objects and the patch merges.
Bye
--
Uwe Bonnes [email protected]
Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt
--------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------
Ab 1.11.2015 Neue Rufnummern! New phone number starting Nov. 1. 2015!
--------- Tel. 06151 1623569 ------- Fax. 06151 1623305 ---------
------------------------------------------------------------------------------
_______________________________________________
OpenOCD-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openocd-devel
