This is an automated email from Gerrit.

Antonio Borneo (borneo.anto...@gmail.com) just uploaded a new patch set to 
Gerrit, which you can find at http://openocd.zylin.com/6054

-- gerrit

commit ce3f0963a4f5fcecc484139f38f22d013287801e
Author: Antonio Borneo <borneo.anto...@gmail.com>
Date:   Thu Feb 11 19:47:46 2021 +0100

    autotools: generate list of NEWS-xx file during configure
    
    Commit 4fc0f3530c51 ("Makefile.am: fix non-POSIX warning from
    automake") uses the BSD make extension '!=' to generate the list
    of files NEWS-xx, but it's not POSIX (yet), it's not backward
    compatible with GNU make 3.82 (used in CentOS 7, EOL scheduled for
    2024) and depending on automake evolution it could trigger again
    the warning 'apparently' just fixed.
    
    Move in configure the generation of the file list.
    The only drawback is that when a developer adds a new NEWS-xx
    file, he/she has to run configure again before 'make distcheck',
    otherwise will get failure.
    
    Change-Id: Ia97e7f4e612655a97702f95e8451040539659b85
    Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com>
    Reported-by: Jan Matyáš <jmat...@codasip.com>

diff --git a/Makefile.am b/Makefile.am
index a6e7ab2..75f0c09 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -42,7 +42,6 @@ if INTERNAL_JIMTCL
 AM_CPPFLAGS += -I$(top_srcdir)/jimtcl \
                           -I$(top_builddir)/jimtcl
 endif
-EXTRA_DIST_NEWS != ls $(srcdir)/NEWS-*
 EXTRA_DIST += \
        BUGS \
        HACKING \
diff --git a/configure.ac b/configure.ac
index 158ba15..f1fa587 100644
--- a/configure.ac
+++ b/configure.ac
@@ -854,6 +854,8 @@ AS_IF([test "x$gcc_warnings" = "xyes"], [
   AC_SUBST([GCC_WARNINGS], [$GCC_WARNINGS])
 ])
 
+AC_SUBST(EXTRA_DIST_NEWS, ["$(echo $srcdir/NEWS-*)"])
+
 AC_CONFIG_FILES([
   Makefile
 ])

-- 


_______________________________________________
OpenOCD-devel mailing list
OpenOCD-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openocd-devel

Reply via email to