On May 23, 2009, at 1:30 PM, Magnus Lundin wrote:
Common people So much soul searching about a oneliner in jtag.c . Setting the current tap state with cmd_queue_cur_state = TAP_RESET isan obvious error as 5 minutes of code inspection in jtag.c will show you.The variable is not used in any dr/ir scan code, It is only used in jtag_add_path_move to find the start state, and for sanity check injtag_add_clocks. It will be overwritten by the next call to jtag_preludeby any ir/dr scan, and all driver code uses tap_get_state() instead. Actually ALL uses of cmd_queue_cur_state should be retired andreplaced by correct accessor function tap_get_state(), as it is now wehave two variables tracing the current tap state, cmd_queue_cur_state and state_follower. I am not saying that nothing will change from this, it most probably will, but the old code is broken and perhaps it is time to fix it. Have a nice weekend Magnus _______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
I don't think anyone is "soul searching" or avoiding this because it in the jtag common code. I know I've been busy the past few days. I believe Zach passed on the issue since he isn't familiar with the code in any way. From what I've seen go by on the list, this has been tested and has either no immediate effect or a positive one. I plan to commit it, but not everyone is working on OpenOCD every day.
-- Rick Altherr kc8...@kc8apf.net"He said he hadn't had a byte in three days. I had a short, so I split it with him."
-- Unsigned
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
