Summary: osaf: port existing daemonization and nid process to systemd
"new-style" daemon
Review request for Trac Ticket(s): 455
Peer Reviewer(s): AndersW, HansF
Pull request to: AndersW,
Affected branch(es): default
Development branch:
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system y
RPM/packaging y
Configuration files y
Startup scripts y
SAF services n
OpenSAF services n
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
This is a first cut at getting OpenSAF to work with systemd. This patch still
leaves the opensafd SysV init.d script, but creates a new opensafd.service file
which calls it. No attempt has been made to convert the individual daemons to
systemd, except for plmcd, which has been converted to a full-blown systemd
daemon. I've built and run this for Fedora 19, OpenSUSE 12.2, and OpenSUSE
13.1.
changeset b14cec02030e81cbeaa1404849971205291f148b
Author: Alex Jones <ajo...@genband.com>
Date: Tue, 17 Jun 2014 11:58:28 -0400
osaf: port existing daemonization and nid process to systemd "new-style"
daemon [#455]
Jun 2 16:55:57 linux-po6q osafrded[16114]: Started Jun 2 16:55:57
linux-po6q
osafrded[16114]: Creation of real-time thread 'OSAF_TMR' FAILED -
'Operation
not permitted' Jun 2 16:55:57 linux-po6q osafrded[16114]: ER
ncs_core_agents_startup FAILED Jun 2 16:55:57 linux-po6q
opensafd[16086]: ER
Failed Jun 2 16:55:57 linux-po6q opensafd[16086]: ER Going for recovery
Jun
2 16:55:57 linux-po6q opensafd[16086]: ER Trying To RESPAWN
/usr/lib64/opensaf/clc-cli/osaf-rded attempt #1 Jun 2 16:55:57
linux-po6q
opensafd[16086]: ER Sending SIGKILL to RDE, pid=16106 Jun 2 16:55:57
linux-
po6q osafrded[16114]: Exiting... Jun 2 16:56:12 linux-po6q
osafrded[16133]:
Started
Linux distros that use a version of systemd < 205 (OpenSUSE 12.1,
OpenSUSE
12.2, Fedora <= 19), fail to start opensafd because, by default, these
versions of systemd do not assign any RT time budgets to the "cpu"
cgroups
for services.
The solution is in two parts: (1) Create an opensafd.service file for
use
by systemd which has cgroup info in it. This cgroup info is not put into
the service file if the systemd version is >= 205. (2) Make plmcd a full
systemd-enabled daemon.
Added Files:
------------
contri
osaf/services/infrastructure/nid/config/opensafd.service.in
Complete diffstat:
------------------
Makefile.common | 2 +
configure.ac | 18 +++
contrib/plmc/Makefile.common | 1 +
contrib/plmc/config/Makefile.am | 6 +
contrib/plmc/config/plmcboot.service.in | 12 ++
contrib/plmc/config/plmcd.conf | 4 +
contrib/plmc/config/plmcd.service.in | 13 ++
contrib/plmc/configure.ac | 16 ++
contrib/plmc/lib/utils/plmc_read_config.c | 8 +
contrib/plmc/plmcd/Makefile.am | 4 +
contrib/plmc/plmcd/plmcd.c | 52 +++++++++-
contrib/plmc/scripts/Makefile.am | 2 +
opensaf.spec.in | 70 +++++++++++-
osaf/services/infrastructure/nid/config/Makefile.am | 12 ++
osaf/services/infrastructure/nid/config/opensafd.service.in | 13 ++
15 files changed, 223 insertions(+), 10 deletions(-)
Testing Commands:
-----------------
"systemctl start opensafd.service" on a distro that uses systemd.
"systemctl start plmcd.service" on a distro that uses systemd.
Testing, Expected Results:
--------------------------
It starts, with no warnings.
Conditions of Submission:
-------------------------
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y OpenSUSE 12.2, OpenSUSE 13.1, Fedora 19
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
