Hi Vu,
I am not able to apply the patch on staging CS #7273:
patching file osaf/libs/agents/saf/lga/Makefile.am
patching file osaf/libs/agents/saf/lga/lga.h
patching file osaf/libs/agents/saf/lga/lga_api.c
Hunk #5 FAILED at 210.
Hunk #8 FAILED at 449.
Hunk #11 FAILED at 709.
Hunk #18 succeeded at 942 with fuzz 2.
Hunk #19 FAILED at 1102.
Hunk #20 FAILED at 1236.
Hunk #22 FAILED at 1352.
6 out of 22 hunks FAILED -- saving rejects to file
osaf/libs/agents/saf/lga/lga_api.c.rej
missing header for unified diff at line 1305 of patch
can't find file to patch at input line 1305
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
| /** Delete this log stream & the associated resources with this
--------------------------
File to patch: ^C
-Nagu
> -----Original Message-----
> From: Vu Minh Nguyen [mailto:[email protected]]
> Sent: 04 February 2016 12:36
> To: Nagendra Kumar
> Cc: [email protected]; Mathivanan Naickan Palanivelu; opensaf-
> [email protected]; [email protected]
> Subject: Re: [devel] [PATCH 0 of 1] Review Request for log: add support for
> cloud resilience feature [#1179]
>
> Hi Nagu,
>
> Thanks. The log file is very useful for me.
>
> I found out the problem. Could you try with the attached patch? Thanks.
>
> Regards, Vu
>
> Quoting Nagendra Kumar <[email protected]>:
>
> > Hi Vu,
> > It is attached in my previous email. Any way attaching
> > the same(osaflogd) again.
> >
> > Thanks
> > -Nagu
> >
> >
> > ----- Original Message -----
> > From: [email protected]
> > To: [email protected]
> > Cc: [email protected], [email protected],
> > [email protected], [email protected]
> > Sent: Wednesday, February 3, 2016 5:39:23 PM GMT +05:30 Chennai,
> > Kolkata, Mumbai, New Delhi
> > Subject: Re: [devel] [PATCH 0 of 1] Review Request for log: add
> > support for cloud resilience feature [#1179]
> >
> > Hi Nagu,
> >
> > Can you please send me the trace log of osaflogd? Thanks.
> >
> > Regards, Vu
> >
> > Quoting Nagendra Kumar <[email protected]>:
> >
> >> Hi Vu,
> >> I was testing this Amf patch along with other "Cluster Resilience"
> >> patches, I am finding difficulties in making Log service coming up.
> >> Can you please check the problem with this patch(if any).
> >>
> >> Attached is the Log sv trace and below is the syslog:
> >>
> >>
> >> Feb 3 17:31:13 PM_SC-1 osafimmloadd: NO Load starting Feb 3
> >> 17:31:13 PM_SC-1 osafimmloadd: NO ***** Loading from XML file
> imm.xml
> >> at /etc/opensaf ***** Feb 3 17:31:13 PM_SC-1 osafimmloadd: NO The
> >> class OpensafImm has been created since it was missing from the
> >> imm.xml load file Feb 3 17:31:13 PM_SC-1 osafimmloadd: IN Class
> >> OsafImmPbeRt created Feb 3 17:31:13 PM_SC-1 osafimmloadd: NO The
> >> class OsafImmPbeRt has been created since it was missing from the
> >> imm.xml load file Feb 3 17:31:13 PM_SC-1 osafimmloadd: NO The
> >> opensafImm=opensafImm,safApp=safImmService object of class
> OpensafImm
> >> has been created since it was missing from the imm.xml load file Feb
> >> 3 17:31:13 PM_SC-1 osafimmnd[18311]: NO Ccb 1 COMMITTED
> (IMMLOADER)
> >> Feb 3 17:31:13 PM_SC-1 osafimmnd[18311]: NO Closing admin owner
> >> IMMLOADER id(1), loading of IMM done Feb 3 17:31:13 PM_SC-1
> >> osafimmnd[18311]: NO NODE STATE-> IMM_NODE_FULLY_AVAILABLE
> 2712 Feb
> >> 3 17:31:13 PM_SC-1 osafimmnd[18311]: NO RepositoryInitModeT is
> >> SA_IMM_INIT_FROM_FILE Feb 3 17:31:13 PM_SC-1 osafimmnd[18311]:
> WA
> >> IMM Access Control mode is DISABLED!
> >> Feb 3 17:31:13 PM_SC-1 osafimmnd[18311]: NO opensafImmNostdFlags
> >> changed to: 0xf6 Feb 3 17:31:13 PM_SC-1 osafimmnd[18311]: NO Epoch
> >> set to 2 in ImmModel Feb 3 17:31:13 PM_SC-1 osafimmd[18299]: NO
> ACT:
> >> New Epoch for IMMND process at node 2010f old epoch: 1 new epoch:2
> >> Feb 3 17:31:13 PM_SC-1 osafimmd[18299]: NO Ruling epoch changed
> to:2
> >> Feb 3 17:31:13 PM_SC-1 osafimmd[18299]: NO Attached Nodes:1
> Accepted
> >> nodes:1 KnownVeteran:0 doReply:0 Feb 3 17:31:13 PM_SC-1
> >> osafimmloadd: NO Load ending normally Feb 3 17:31:13 PM_SC-1
> >> osafimmnd[18311]: NO SERVER STATE:
> >> IMM_SERVER_LOADING_SERVER --> IMM_SERVER_READY Feb 3
> 17:31:13
> >> PM_SC-1 osafimmnd[18311]: NO ABT ImmModel received
> scAbsenceAllowed
> >> 900 Feb 3 17:31:13 PM_SC-1 osaflogd[18324]: Started Feb 3 17:31:13
> >> PM_SC-1 osaflogd[18324]: NO LOGSV_DATA_GROUPNAME not found Feb
> 3
> >> 17:31:13 PM_SC-1 osaflogd[18324]: NO LOG root directory is:
> >> "/var/log/opensaf/saflog"
> >> Feb 3 17:31:13 PM_SC-1 osaflogd[18324]: NO LOG data group is: ""
> >> Feb 3 17:31:13 PM_SC-1 osaflogd[18324]: NO LGS_MBCSV_VERSION = 5
> Feb
> >> 3 17:31:13 PM_SC-1 osafimmnd[18311]: NO Implementer connected:
> >> 1 (safLogService) <2, 2010f>
> >> Feb 3 17:31:13 PM_SC-1 osafimmnd[18311]: NO implementer for class
> >> 'OpenSafLogConfig' is safLogService => class extent is safe.
> >> Feb 3 17:31:13 PM_SC-1 osafimmnd[18311]: NO implementer for class
> >> 'SaLogStreamConfig' is safLogService => class extent is safe.
> >> Feb 3 17:31:13 PM_SC-1 osafimmnd[18311]: NO Implementer locally
> >> disconnected. Marking it as doomed 1 <2, 2010f> (safLogService) Feb
> >> 3 17:31:13 PM_SC-1 osafimmnd[18311]: NO Implementer disconnected 1
> >> <2, 2010f> (safLogService) Feb 3 17:31:53 PM_SC-1 opensafd[18248]:
> >> ER Timed-out for response from LOGD Feb 3 17:31:53 PM_SC-1
> >> opensafd[18248]: ER Feb 3 17:31:53 PM_SC-1 opensafd[18248]: ER
> Going
> >> for recovery Feb 3 17:31:53 PM_SC-1 opensafd[18248]: ER Trying To
> >> RESPAWN /usr/local/lib/opensaf/clc-cli/osaf-logd attempt #1 Feb 3
> >> 17:31:53 PM_SC-1 opensafd[18248]: ER Sending SIGABRT to LOGD,
> >> pid=18324, (origin parent pid=18319) Feb 3 17:31:53 PM_SC-1
> >> opensafd[18248]: ER Sending SIGKILL to LOGD,
> >> pid=18319
> >> Feb 3 17:32:08 PM_SC-1 osaflogd[18359]: Started Feb 3 17:32:08
> >> PM_SC-1 osaflogd[18359]: NO LOGSV_DATA_GROUPNAME not found Feb
> 3
> >> 17:32:08 PM_SC-1 osaflogd[18359]: NO LOG root directory is:
> >> "/var/log/opensaf/saflog"
> >> Feb 3 17:32:08 PM_SC-1 osaflogd[18359]: NO LOG data group is: ""
> >> Feb 3 17:32:08 PM_SC-1 osaflogd[18359]: NO LGS_MBCSV_VERSION = 5
> Feb
> >> 3 17:32:08 PM_SC-1 osafimmnd[18311]: NO Implementer connected:
> >> 2 (safLogService) <14, 2010f>
> >> Feb 3 17:32:08 PM_SC-1 osafimmnd[18311]: NO Implementer locally
> >> disconnected. Marking it as doomed 2 <14, 2010f> (safLogService) Feb
> >> 3 17:32:08 PM_SC-1 osafimmnd[18311]: NO Implementer disconnected 2
> >> <14, 2010f> (safLogService)
> >>
> >> Thanks
> >> -Nagu
> >>
> >>> -----Original Message-----
> >>> From: Vu Minh Nguyen [mailto:[email protected]]
> >>> Sent: 28 January 2016 10:11
> >>> To: [email protected]; [email protected];
> >>> Mathivanan Naickan Palanivelu
> >>> Cc: [email protected]
> >>> Subject: Re: [devel] [PATCH 0 of 1] Review Request for log: add
> >>> support for cloud resilience feature [#1179]
> >>>
> >>> Hi,
> >>>
> >>> I forgot adding information. To build the #1179 patch successfully,
> >>> need
> >>> #777 pushed.
> >>>
> >>> Regards, Vu.
> >>>
> >>>
> >>> >-----Original Message-----
> >>> >From: Vu Minh Nguyen [mailto:[email protected]]
> >>> >Sent: Thursday, January 28, 2016 11:13 AM
> >>> >To: [email protected]; [email protected];
> >>> >[email protected]
> >>> >Cc: [email protected]
> >>> >Subject: [devel] [PATCH 0 of 1] Review Request for log: add support
> >>> >for
> >>> cloud
> >>> >resilience feature [#1179]
> >>> >
> >>> >Summary: log: add support for cloud resilience feature [#1179]
> >>> >Review request for Trac Ticket(s): #1179 Peer Reviewer(s): Lennart,
> >>> >Anders, Mathi Pull request to: Lennart Affected branch(es): Default
> >>> >Development
> >>> >branch: Default
> >>> >
> >>> >--------------------------------
> >>> >Impacted area Impact y/n
> >>> >--------------------------------
> >>> > Docs n
> >>> > Build system n
> >>> > RPM/packaging n
> >>> > Configuration files n
> >>> > Startup scripts n
> >>> > SAF services y
> >>> > OpenSAF services n
> >>> > Core libraries n
> >>> > Samples n
> >>> > Tests n
> >>> > Other n
> >>> >
> >>> >
> >>> >Comments (indicate scope for each "y" above):
> >>> >---------------------------------------------
> >>> > <<EXPLAIN/COMMENT THE PATCH SERIES HERE>>
> >>> >
> >>> >changeset 90a6bd73b83a52d561572d171a7042ac319511cb
> >>> >Author: Lennart Lund <[email protected]>
> >>> >Date: Fri, 22 Jan 2016 12:20:27 +0700
> >>> >
> >>> > log: add support for cloud resilience feature [#1179]
> >>> >
> >>> > The patch makes LOG service be able to handle the case that both
> >>> >SC nodes
> >>> > are down at the same time. When one or both nodes go up again the
> >>> log
> >>> > service must be able to resume its work preferably without actions
> >>> by
> >>> >the
> >>> > clients.
> >>> >
> >>> > A log client should not have to be aware of if one or both SC
> >>> >nodes
> >>> are
> >>> > down. The only thing that should happen is that a TRY AGAIN (and
> >>> >in some
> >>> > cases TIMEOUT) returned. It is the responsibility of the client to
> >>> decide
> >>> > how to handle this.
> >>> >
> >>> >
> >>> >Added Files:
> >>> >------------
> >>> > osaf/libs/agents/saf/lga/lga_state.c
> >>> > osaf/libs/agents/saf/lga/lga_state.h
> >>> > osaf/services/saf/logsv/lgs/lgs_recov.cc
> >>> > osaf/services/saf/logsv/lgs/lgs_recov.h
> >>> > osaf/services/saf/logsv/README-HEADLESS
> >>> > tests/logsv/tet_Log_recov.c
> >>> >
> >>> >
> >>> >Complete diffstat:
> >>> >------------------
> >>> > osaf/libs/agents/saf/lga/Makefile.am | 6 +-
> >>> > osaf/libs/agents/saf/lga/lga.h | 53 +++-
> >>> > osaf/libs/agents/saf/lga/lga_api.c | 858
> >>> >+++++++++++++++++++++++++++++++++++++----------------
> >>> > osaf/libs/agents/saf/lga/lga_mds.c | 46 ++-
> >>> > osaf/libs/agents/saf/lga/lga_state.c | 670
> >>> >++++++++++++++++++++++++++++++++++++++++++
> >>> > osaf/libs/agents/saf/lga/lga_state.h | 41 ++
> >>> > osaf/libs/agents/saf/lga/lga_util.c | 94 +++++-
> >>> > osaf/services/saf/logsv/README | 2 -
> >>> > osaf/services/saf/logsv/README-HEADLESS | 230 ++++++++++++++
> >>> > osaf/services/saf/logsv/lgs/Makefile.am | 6 +-
> >>> > osaf/services/saf/logsv/lgs/lgs.h | 12 +
> >>> > osaf/services/saf/logsv/lgs/lgs_cb.h | 14 +
> >>> > osaf/services/saf/logsv/lgs/lgs_evt.cc | 66 +++-
> >>> > osaf/services/saf/logsv/lgs/lgs_evt.h | 5 +
> >>> > osaf/services/saf/logsv/lgs/lgs_file.cc | 5 +
> >>> > osaf/services/saf/logsv/lgs/lgs_file.h | 1 +
> >>> > osaf/services/saf/logsv/lgs/lgs_filehdl.cc | 423
> >>> >++++++++++++++++++++++++++-
> >>> > osaf/services/saf/logsv/lgs/lgs_filehdl.h | 21 +
> >>> > osaf/services/saf/logsv/lgs/lgs_imm.cc | 541
> >>> >+++++++++++++++++++++++++++++++++-
> >>> > osaf/services/saf/logsv/lgs/lgs_main.cc | 134 +++++++-
> >>> > osaf/services/saf/logsv/lgs/lgs_mbcsv.cc | 22 +-
> >>> > osaf/services/saf/logsv/lgs/lgs_recov.cc | 748
> >>> >+++++++++++++++++++++++++++++++++++++++++++++++
> >>> > osaf/services/saf/logsv/lgs/lgs_recov.h | 37 ++
> >>> > osaf/services/saf/logsv/lgs/lgs_stream.cc | 99 ++++-
> >>> > osaf/services/saf/logsv/lgs/lgs_stream.h | 30 +-
> >>> > osaf/services/saf/logsv/lgs/lgs_util.cc | 50 ++-
> >>> > osaf/services/saf/logsv/lgs/lgs_util.h | 4 +
> >>> > tests/logsv/Makefile.am | 1 +
> >>> > tests/logsv/README | 4 +
> >>> > tests/logsv/logtest.c | 290 ++++++++++++++++-
> >>> > tests/logsv/logtest.h | 57 +++
> >>> > tests/logsv/logtestfr.c | 6 +-
> >>> > tests/logsv/saflogtest.c | 46 ++-
> >>> > tests/logsv/tet_Log_misc.c | 24 +-
> >>> > tests/logsv/tet_Log_recov.c | 1837
> >>>
> >+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >>> +++++
> >>> >++++++++++++++++++++++++++++++++++++++++++++++++++
> >>> > 35 files changed, 6069 insertions(+), 414 deletions(-)
> >>> >
> >>> >
> >>> >Testing Commands:
> >>> >-----------------
> >>> > Test suite #9 and #10 are added to test this feature, but needs
> >>> >to have IMM (#1625) and AMF (#1620) pushed.
> >>> >
> >>> > For now, to test it, can hard code "lgs_cb.scAbsenceAllowed = 1",
> >>> > to make logsv enter headless mode, then run all test suites.
> >>> >
> >>> >
> >>> >Testing, Expected Results:
> >>> >--------------------------
> >>> > All tests PASS
> >>> >
> >>> >
> >>> >Conditions of Submission:
> >>> >-------------------------
> >>> > Get ack from reviewers. Hope getting them within 03 weeks.
> >>> >
> >>> >
> >>> >Arch Built Started Linux distro
> >>> >-------------------------------------------
> >>> >mips n n
> >>> >mips64 n n
> >>> >x86 n n
> >>> >x86_64 n n
> >>> >powerpc n n
> >>> >powerpc64 n n
> >>> >
> >>> >
> >>> >Reviewer Checklist:
> >>> >-------------------
> >>> >[Submitters: make sure that your review doesn't trigger any
> >>> >checkmarks!]
> >>> >
> >>> >
> >>> >Your checkin has not passed review because (see checked entries):
> >>> >
> >>> >___ Your RR template is generally incomplete; it has too many
> >>> blank entries
> >>> > that need proper data filled in.
> >>> >
> >>> >___ You have failed to nominate the proper persons for review and
> push.
> >>> >
> >>> >___ Your patches do not have proper short+long header
> >>> >
> >>> >___ You have grammar/spelling in your header that is unacceptable.
> >>> >
> >>> >___ You have exceeded a sensible line length in your
> >>> headers/comments/text.
> >>> >
> >>> >___ You have failed to put in a proper Trac Ticket # into your commits.
> >>> >
> >>> >___ You have incorrectly put/left internal data in your comments/files
> >>> > (i.e. internal bug tracking tool IDs, product names etc)
> >>> >
> >>> >___ You have not given any evidence of testing beyond basic build
> tests.
> >>> > Demonstrate some level of runtime or other sanity testing.
> >>> >
> >>> >___ You have ^M present in some of your files. These have to be
> removed.
> >>> >
> >>> >___ You have needlessly changed whitespace or added whitespace
> crimes
> >>> > like trailing spaces, or spaces before tabs.
> >>> >
> >>> >___ You have mixed real technical changes with whitespace and other
> >>> > cosmetic code cleanup changes. These have to be separate commits.
> >>> >
> >>> >___ You need to refactor your submission into logical chunks; there is
> >>> > too much content into a single commit.
> >>> >
> >>> >___ You have extraneous garbage in your review (merge commits etc)
> >>> >
> >>> >___ You have giant attachments which should never have been sent;
> >>> > Instead you should place your content in a public tree to be pulled.
> >>> >
> >>> >___ You have too many commits attached to an e-mail; resend as
> threaded
> >>> > commits, or place in a public tree for a pull.
> >>> >
> >>> >___ You have resent this content multiple times without a clear
> indication
> >>> > of what has changed between each re-send.
> >>> >
> >>> >___ You have failed to adequately and individually address all of the
> >>> > comments and change requests that were proposed in the initial
> review.
> >>> >
> >>> >___ You have a misconfigured ~/.hgrc file (i.e. username, email
> >>> >etc)
> >>> >
> >>> >___ Your computer have a badly configured date and time; confusing
> the
> >>> > the threaded patch review.
> >>> >
> >>> >___ Your changes affect IPC mechanism, and you don't present any
> results
> >>> > for in-service upgradability test.
> >>> >
> >>> >___ Your changes affect user manual and documentation, your patch
> series
> >>> > do not contain the patch that updates the Doxygen manual.
> >>> >
> >>> >
> >>> >-------------------------------------------------------------------
> >>> >----
> >>> >----
> >>> ---
> >>> >Site24x7 APM Insight: Get Deep Visibility into Application
> >>> >Performance APM + Mobile APM + RUM: Monitor 3 App instances at
> just
> >>> >$35/Month Monitor end-to-end web transactions and take corrective
> >>> >actions now Troubleshoot faster and improve end-user experience.
> Signup Now!
> >>> >http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
> >>> >_______________________________________________
> >>> >Opensaf-devel mailing list
> >>> >[email protected]
> >>> >https://lists.sourceforge.net/lists/listinfo/opensaf-devel
> >>>
> >>>
> >>> --------------------------------------------------------------------
> >>> ----------
> >>> Site24x7 APM Insight: Get Deep Visibility into Application
> >>> Performance APM + Mobile APM + RUM: Monitor 3 App instances at just
> >>> $35/Month Monitor end-to-end web transactions and take corrective
> >>> actions now Troubleshoot faster and improve end-user experience.
> >>> Signup Now!
> >>> http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
> >>> _______________________________________________
> >>> Opensaf-devel mailing list
> >>> [email protected]
> >>> https://lists.sourceforge.net/lists/listinfo/opensaf-devel
>
>
------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
