Hi Alex
Thanks, it looks much better. So I tried ‘killall amf_container_demo” 10 times really quickly: 2018-08-16 13:43:22.652 SC-1 osafamfnd[286]: NO 'safSu=SU1,safSg=Container,safApp=Container' restarts have reached configured limit of 10 2018-08-16 13:43:22.653 SC-1 osafamfnd[286]: NO 'safSu=SU1,safSg=Container,safApp=Container' SU restart probation timer stopped 2018-08-16 13:43:22.654 SC-1 osafamfnd[286]: NO SU failover probation timer started (timeout: 1200000000000 ns) 2018-08-16 13:43:22.655 SC-1 osafamfnd[286]: NO Performing failover of 'safSu=SU1,safSg=Container,safApp=Container' (SU failover count: 1) 2018-08-16 13:43:22.655 SC-1 osafamfnd[286]: NO 'safComp=Container,safSu=SU1,safSg=Container,safApp=Container' recovery action escalated from 'componentRestart' to 'suFailover' 2018-08-16 13:43:22.656 SC-1 osafamfnd[286]: NO 'safComp=Container,safSu=SU1,safSg=Container,safApp=Container' faulted due to 'avaDown' : Recovery is 'suFailover' 2018-08-16 13:43:22.657 SC-1 osafamfnd[286]: NO Terminating components of 'safSu=SU1,safSg=Container,safApp=Container'(abruptly & unordered) 2018-08-16 13:43:22.658 SC-1 osafamfnd[286]: NO 'safSu=SU1,safSg=Container,safApp=Container' Presence State INSTANTIATED => TERMINATING 2018-08-16 13:43:22.659 SC-1 osafamfnd[286]: NO 'safSu=SU1,safSg=Container,safApp=Container' Presence State TERMINATING => TERMINATING 2018-08-16 13:43:22.667 SC-1 ubuntu: CONTAINED COMP NAME:safComp=Contained_1,safSu=SU1,safSg=Contained_2N,safApp=Contained_2N 2018-08-16 13:43:22.670 SC-1 osafamfnd[286]: NO 'safSu=SU1,safSg=Container,safApp=Container' Presence State TERMINATING => UNINSTANTIATED 2018-08-16 13:43:22.671 SC-1 osafamfnd[286]: NO Terminated all components in 'safSu=SU1,safSg=Container,safApp=Container' 2018-08-16 13:43:22.671 SC-1 osafamfnd[286]: NO Informing director of sufailover amf-state su: safSu=SU1,safSg=Contained_2N,safApp=Contained_2N saAmfSUAdminState=UNLOCKED(1) saAmfSUOperState=ENABLED(1) saAmfSUPresenceState=INSTANTIATED(3) saAmfSUReadinessState=IN-SERVICE(2) amf-state si: safSi=SC-2N,safApp=OpenSAF saAmfSIAdminState=UNLOCKED(1) saAmfSIAssignmentState=FULLY_ASSIGNED(2) safSi=Contained_2N_1,safApp=Contained_2N saAmfSIAdminState=UNLOCKED(1) saAmfSIAssignmentState=FULLY_ASSIGNED(2) Thanks Gary From: Alex Jones <ajo...@rbbn.com> Organization: Ribbon Date: Thursday, 16 August 2018 at 3:41 am To: Gary Lee <gary....@dektech.com.au>, <hans.nordeb...@ericsson.com>, <ravisekhar.ko...@oracle.com>, <nagen...@hasolutions.in> Cc: <opensaf-devel@lists.sourceforge.net> Subject: Re: [PATCH 1/1] amf: add support for container/contained [#70] G'day Gary, I see you were adding the XML file dynamically with "immcfg -f". I hadn't tried that. I hadn't tried killing the sample app, either. Here is a patch that should fix both issues. Apply it on top of the latest big one I sent. Alex On 08/13/2018 10:37 PM, Gary Lee wrote: NOTICE: This email was received from an EXTERNAL sender Hi Alex I modified AppConfig-container.xml and changed saAmfSgtRedundancyModel from 4 (NwayAct) to 1 (2N). The xml still loads and I could unlock, resulting in: root@SC-1:/var/log# immlist safVersion=1,safSgType=Container Name Type Value(s) ======================================================================== safVersion SA_STRING_T safVersion=1 saAmfSgtValidSuTypes SA_NAME_T safVersion=1,safSuType=Container (32) saAmfSgtRedundancyModel SA_UINT32_T 1 (0x1) safSISU=safSu=SU2\,safSg=Container\,safApp=Container,safSi=Container,safApp=Container saAmfSISUHAState=STANDBY(2) saAmfSISUHAReadinessState=READY_FOR_ASSIGNMENT(1) safSISU=safSu=SU1\,safSg=Container\,safApp=Container,safSi=Container,safApp=Container saAmfSISUHAState=ACTIVE(1) saAmfSISUHAReadinessState=READY_FOR_ASSIGNMENT(1) Also, have you tried killing the amf_container_demo binary? Thanks Gary On 14/08/18 05:00, Alex Jones wrote: Hi Gary, I just resubmitted a new patch which breaks out the different components, and addresses the other comments here. But, #2 (rejecting all but NWay-active for container) should already be in there. Is there a specific test you ran that didn't work? Alex On 08/13/2018 02:43 AM, Gary Lee wrote: NOTICE: This email was received from an EXTERNAL sender Hi Alex Some initial comments: 0. Is it possible to split up the patch into amfd / amfnd / common / samples. Just makes it easier to reply inline. 1. Please compile the container demo by default, and make amf_container_script world executable. Eg. diff --git a/samples/amf/Makefile.am b/samples/amf/Makefile.am index 447dedd..7ebf9c3 100644 --- a/samples/amf/Makefile.am +++ b/samples/amf/Makefile.am @@ -19,5 +19,5 @@ include $(top_srcdir)/Makefile.common MAINTAINERCLEANFILES = Makefile.in -SUBDIRS = sa_aware non_sa_aware wrapper proxy api_demo +SUBDIRS = sa_aware non_sa_aware wrapper proxy api_demo container diff --git a/samples/amf/container/amf_container_script b/samples/amf/container/amf_container_script old mode 100644 new mode 100755 diff --git a/samples/configure.ac b/samples/configure.ac index 7cf803e..9765d54 100644 --- a/samples/configure.ac +++ b/samples/configure.ac @@ -67,6 +67,7 @@ AC_CONFIG_FILES([ \ amf/wrapper/Makefile \ amf/proxy/Makefile \ amf/api_demo/Makefile \ + amf/container/Makefile \ cpsv/Makefile \ cpsv/ckpt_demo/Makefile \ cpsv/ckpt_track_demo/Makefile \ 2. We should probably reject CCBs that set saAmfSgtRedundancyModel to anything other than NWayActive, for Containers. 3. Do we need to bump the msg format version to AVSV_AVD_AVND_MSG_FMT_VER_8? An old amfnd will assert if it gets an AVSV_D2N_CONTAINED_SU_MSG_INFO msg. Thanks Gary ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel