On Fri, Apr 11, 2008 at 11:40 AM, Aktiv Co. Aleksey Samsonov wrote:We are going to release tested patch for the current version of your code in a couple of days. It fixes a number of bugs in Rutoken code and changes card-rutoken.c file to meet OpenSC coding standards.
Patch for trunk revision 3476 is in attachment. I believe that whitespace changes to existing code in this patch is are necessary because otherwise some files will not be formatted properly. Alon Bar-Lev: > Please also explain why the pkcs15-prkey-rutoken.c is needed, there is > not prkey specific file for any other card. This file is necessary to avoid redoubling of code. Alon Bar-Lev: > Also at libopensc.exports you can see that only rutoken has card > specific exports, this should also be modified. Patch opensc-0.11.4.trunk-r3476_rutoken-0.3.2_2.diff (for opensc-0.11.4.trunk-r3476-0.11.4.trunk-r3476_rutoken-0.3.2.diff) isdraft. This patch solves the problem with exported functions. (Instead of pkcs15-prkey-rutoken.c it'll be rutoken-prkey.h). If this solution is better than previous one, but it's inappropriate to use line '#include "../libopensc/rutoken-prkey.h"' in the file src/pkcs15init/pkcs15-rutoken.c, then I can fully split the file rutoken-prkey.h.
opensc-0.11.4.trunk-r3476-0.11.4.trunk-r3476_rutoken-0.3.2.diff.gz
Description: application/gzip
opensc-0.11.4.trunk-r3476_rutoken-0.3.2_2.diff.gz
Description: application/gzip
_______________________________________________ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
