Much better!!!
Can you please rebase and send all your modifications as single patch?

Thanks!

On 4/17/08, Aktiv Co. Aleksey Samsonov <[EMAIL PROTECTED]> wrote:
>
>  Alon Bar-Lev:
>
> >
> > > Patch opensc-0.11.4.trunk-r3476_rutoken-0.3.2_2.diff
> (for
> > >
> opensc-0.11.4.trunk-r3476-0.11.4.trunk-r3476_rutoken-0.3.2.diff)
> > > is draft. This patch solves the problem with exported functions.
> (Instead of
> > > pkcs15-prkey-rutoken.c it'll be rutoken-prkey.h). If this solution is
> better
> > > than previous one, but it's inappropriate to use line '#include
> > > "../libopensc/rutoken-prkey.h"' in the file
> > > src/pkcs15init/pkcs15-rutoken.c, then I can fully split
> the
> > > file rutoken-prkey.h.
> > >
> >
> > Having code in include file is worse.
> > Please try to convert the rutoken specific stuff into pkcs15 data
> structures.
> >
>
>  Patch opensc-0.11.4.trunk-r3477_rutoken-0.3.2_3.diff (for
> opensc-0.11.4.trunk-r3476-0.11.4.trunk-r3476_rutoken-0.3.2.diff)
> is draft2.
>
>
>
_______________________________________________
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel

Reply via email to