Hi Martin,

Understood and thanks for testing the code. I've attached the less intrusive version of the patch. The "card-pteid.c" code was changed to reflect this.

Regards,
João

Attachment: implicit_pin_change.patch
Description: Binary data




On Sep 25, 2009, at 20:19, Martin Paljak wrote:

Hello,
On 25.09.2009, at 0:04, João Poupino wrote:
I've attached a small patch that uses your suggestion. I've successfully tested it with both versions of the Portuguese eID card, with a SPR532 pinpad reader: one version uses an implicit change pin operation and the other uses the (normal) explicit pin change operation.

I checked the patch and the -pteid things on your trac. As you have a single card-pteid.c file with support for two different cards and quite a heavy pin_cmd implementation then maybe it is better to not pollute the PKCS#15 namespace with a new flag that does not yet have any use outside of a single card driver.

Worked for me/EstEID as well otherwise.

--
Martin Paljak
http://martin.paljak.pri.ee
+372.515.6495





_______________________________________________
opensc-devel mailing list
opensc-devel@lists.opensc-project.org
http://www.opensc-project.org/mailman/listinfo/opensc-devel

Reply via email to