Ludovic Rousseau wrote: > > I made an attempt to kick change 1 loose. > > Done. > The status is now "Merged" and the change is available in git at > https://www.opensc-project.org/codereview/p/OpenSC but not yet on > git://github.com/OpenSC/OpenSC.git
I guess github is synced only periodically. > I note a bug/typo in the patch for > https://www.opensc-project.org/codereview/#patch,unified,1,2,src/libopensc/internal.h > In the Doxygen comment it should be "reader" instead of "reder" Ouch. Then please don't give +2 but instead -2 and don't submit but give review in an inline comment. I would then have fixed it and pushed an updated patch. > > The detailed steps I did are as follows: > > > > cd /tmp > > git clone https://www.opensc-project.org/codereview/p/OpenSC > > cd OpenSC > > git config remote.origin.push HEAD:refs/for/staging > > scp -p -P 8882 www.opensc-project.org:hooks/commit-msg .git/hooks/ > > Failed for me: > $ scp -p -P 8882 www.opensc-project.org:hooks/commit-msg .git/hooks/ > Host key fingerprint is ab:d9:2d:c0:2f:4c:4e:bd:10:03:bd:d2:ef:2f:4f:61 > +--[ RSA 1024]----+ > | . | > | . . | > | o . | > | . = | > | o =S E | > | * oo . | > | = =... | > | ++*o | > | o..=+ | > +-----------------+ > > Permission denied (publickey). > > > I added my SSH public key on my gerrit account but the access is > still denied. So the username between local host and gerrit doesn't match. Check https://www.opensc-project.org/codereview/#settings And possibly add: Host opensc-gerrit Hostname www.opensc-project.org Port 8882 User yourusernamefromgerrit Then you can instead use: scp -p opensc-gerrit:hooks/commit-msg .git/hooks/ (And ssh opensc-gerrit gerrit review ... for setting code-review and doing submit.) //Peter _______________________________________________ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel
