On Wed, 2009-09-02 at 14:55 +0530, Spoorthy H.S wrote: > > Mark Phalan wrote: > >>> > >>> > >>>> > >>>> Exported Interfaces > >>>> ------------------- > >>>> /usr/perl5/5.8.4/man/man3/Crypt::CBC.3 Man pages for the package > >>>> Crypt-CBC > >>>> Crypt::CBC perl module > >>>> /usr/perl5/5.8.4/crypt-cbc/CBC.pm > >>>> > >>>> > >>> The above looks wrong. There shouldn't be a crypt-cbc directory in the > >>> 5.8.4 "root". It should probably go somewhere in /usr/perl5/vendor_perl. > >>> > >>> Now that Perl 5.10 has been delivered shouldn't a version for 5.10 also > >>> be included. > >>> > >>> > >> I am installing it onto usr/perl5/vendor_perl/5.8.4/crypt-cbc. > >> > > > > I'm not a Perl expert but that still looks wrong to me: > > > > Shouldn't the path look something like this? > > usr/perl5/vendor_perl/5.8.4/Crypt/CBC.pm > > > > FYI: > > On snv_120 > > $ perl -e 'print "@INC\n"' > > /usr/perl5/5.8.4/lib/i86pc-solaris-64int /usr/perl5/5.8.4/lib > > /usr/perl5/site_perl/5.8.4/i86pc-solaris-64int /usr/perl5/site_perl/5.8.4 > > /usr/perl5/site_perl /usr/perl5/vendor_perl/5.8.4/i86pc-solaris-64int > > /usr/perl5/vendor_perl/5.8.4 /usr/perl5/vendor_perl . > > > > Anyway, the user shouldn't have to do anything special to use this > > module other than specifying something like 'use Crypt::CBC' > > > > > So, what will be the path for this ? If its > usr/perl5/vendor_perl/5.8.4/i86pc-solaris-64int, I will update the ARC > one pager.
I think CBC.pm should be installed as usr/perl5/vendor_perl/5.8.4/Crypt/CBC.pm > >> The > >> deliverable of Perl 5.10 will be upgraded once I build the dependency > >> package also. The final plan is to release this package for perl 5.10 > >> itself. > >> > > > > If this package has a dependency then shouldn't it be specified as a > > dependency for this case? Can this module be delivered without the > > dependency? > > > > > This package cant be delivered without the dependency package. I am in > the process of packaging it. ARC folk might want to advise here - at least the package should be listed as a dependency. > >>> > >>> > >>>> Imported Interfaces > >>>> ------------------- > >>>> MD5 > >>>> > >>>> Not An Interface > >>>> -------------------- > >>>> /usr/demo/crypt-cbc/Makefile.PL - Makefile perl file > >>>> > >>>> > >>> Whats the above makefile for? > >>> > >>> > >> This can be removed. I am keeping this for the reference. The Readme of > >> the package gives details of building this file using "perl Makefile.PL" > >> > > > > I'm still unclear as to what the Makefile.PL is for. Is this the > > Makefile.PL included in the crypt-cbc distribution? If so I don't see > > any need to deliver it to Solaris. > > > > > Makefile.PL is required. It comes with the crypt-cbc package. It > generates the Makefile required for building the package and creation of > some files like blib/man3/<man page>. It sounds like its part of the build system for the Perl module. It shouldn't be part of the installation. > >>> ... > >>> > >>> > >>>> /usr/demo/crypt-cbc/t/Blowfish.t > >>>> /usr/demo/crypt-cbc/t/Blowfish_PP.t > >>>> /usr/demo/crypt-cbc/t/CAST5.t > >>>> /usr/demo/crypt-cbc/t/DES.t > >>>> /usr/demo/crypt-cbc/t/IDEA.t > >>>> /usr/demo/crypt-cbc/t/PCBC.t > >>>> /usr/demo/crypt-cbc/t/Rijndael.t > >>>> /usr/demo/crypt-cbc/t/Rijndael_compat.t > >>>> /usr/demo/crypt-cbc/t/func.t > >>>> /usr/demo/crypt-cbc/t/null_data.t > >>>> /usr/demo/crypt-cbc/t/onezeropadding.t > >>>> /usr/demo/crypt-cbc/t/parameters.t > >>>> /usr/demo/crypt-cbc/t/preexisting.t > >>>> > >>> Aren't the above automated tests? Why are they being delivered > >>> in /usr/demo? > >>> > >> If /usr/demo is not the right place to keep these files, where these > >> should be placed ? > >> > > > > If they are tests then they should probably be integrated into a test > > gate or simply not delivered at all. > > > > > I am very unsure of whether these should be included or not. These come > with the package and will be required to test the package once it gets > installed. So, i have kept these. They should not be included. Thanks, -M
