>> Oops! Wrong patch! Correct one attached. If you feel like testing the >> wrong one, go ahead, but there are some later non-essential adjustments. >> >> diff --git a/crypto/ec/ecp_nistz256.c b/crypto/ec/ecp_nistz256.c >> index bf3fcc6..33b07ce 100644 >> --- a/crypto/ec/ecp_nistz256.c >> +++ b/crypto/ec/ecp_nistz256.c >> @@ -637,7 +637,7 @@ static void ecp_nistz256_windowed_mul(const EC_GROUP * >> group, >> ecp_nistz256_point_double(&row[10 - 1], &row[ 5 - 1]); >> ecp_nistz256_point_add (&row[15 - 1], &row[14 - 1], &row[1 - 1]); >> ecp_nistz256_point_add (&row[11 - 1], &row[10 - 1], &row[1 - 1]); >> - ecp_nistz256_point_add (&row[16 - 1], &row[15 - 1], &row[1 - 1]); >> + ecp_nistz256_point_double(&row[16 - 1], &row[ 8 - 1]); >> } >> >> index = 255; > > I can believe that this fixes the issue, but it's just masking it, no?
It's not a coincidence that I didn't say "fixes the issue" or "solves the problem", but "produces correct result". BTW, it seems to be unrelated to the original problem with carries handling in assembly. ______________________________________________________________________ OpenSSL Project http://www.openssl.org Development Mailing List openssl-dev@openssl.org Automated List Manager majord...@openssl.org
