On 25 April 2015 at 05:43, Ben Nemec <openst...@nemebean.com> wrote: > On 04/24/2015 07:11 AM, Russell Bryant wrote: >> On 04/24/2015 07:21 AM, Amrith Kumar wrote: >>> We had a hypothesis about why +0 was rarely used (never conclusively >>> proved). Our hypothesis was that since Stackalytics didn't count +0's >>> it led to an increased propensity to -1 something. It would be >>> wonderful if we could try the experiment of giving credit for 0's and >>> seeing if it changes behavior. >> >> I think this makes a lot of sense. These stats really do drive >> behavior. I'd certainly be open to a patch to reviewstats [1] to count >> +0 comments and I think it would be good for stackalytics to consider >> the same. >> >> [1] http://git.openstack.org/cgit/openstack-infra/reviewstats >> > > I actually looked at doing this a while ago, but unfortunately the json > data we were getting from Gerrit didn't include no scores. That may > have been pre-Gerrit upgrade so it's possible it will have changed, but > it's worth noting that we may just not have the ability to track this.
I believe we'll need to switch to the REST JSON API, which gertty uses and gets comments -> some nontrivial refactoring implied, and I shudder to think about the performance impact. I've wanted to rewrite reviewstats for a while... this might be the trigger... -Rob -- Robert Collins <rbtcoll...@hp.com> Distinguished Technologist HP Converged Cloud __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev