I pushed https://review.openstack.org/#/c/425023 as one of approaches.
On Wed, Jan 25, 2017 at 10:29 AM Anna Taraday <akamyshnik...@mirantis.com> wrote: > Thanks for bringing this up! > > I was assuming that from Ocata everyone should switch from usage 'old' > TunnelTypeDriver to updated one. > > Revering both back to session means reverting all refactor and this is not > in line with enginefacade work and as I remember some of OVO patches we > waiting for this refactor too. > > I we can duplicate methods or we can check type of the argument if session > or context and proceed differently. I will push patch for this ASAP. > > On Wed, Jan 25, 2017 at 2:15 AM Ihar Hrachyshka <ihrac...@redhat.com> > wrote: > >> Hi Anna, >> >> I see that as part of [1], we changed the argument type for the $subj >> function from session to context. Sadly, it turns out we still call it >> with a session from the 'old' TunnelTypeDriver. I suspect the same >> issue may affect allocate_fully_specified_segment. >> >> I assume that means all 'old' tunnel type drivers are broken. Should >> we fix it by duplicating those two functions for old and new cases >> too? Or should we revert both of them back to session? (I assume the >> former, since the latter is not in line with enginefacade work.) >> >> [1] >> https://review.openstack.org/#/c/398873/10/neutron/plugins/ml2/drivers/helpers.py >> >> Thanks in advance, >> Ihar >> > -- > Regards, > Ann Taraday > -- Regards, Ann Taraday
__________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
