On Wed, Sep 07, 2011, Jay Pipes <[email protected]> wrote: > On Wed, Sep 7, 2011 at 12:24 PM, Johannes Erdfelt <[email protected]> > wrote: > > Why do core members have that "merge and close" option? Wouldn't it make > > more sense to restrict that to the Jenkins account? > > > > I still think you can do a gated trunk, even with github pull requests. > > Please show me a project on GitHub that does.
This is a weak argument. Even if no one has done it yet doesn't make it a poor choice. If a requirement is a gated trunk (which I think is a perfectly reasonable requirement), then you only need to restrict pushes to Jenkins. I can certainly comment on pull requests that I can't push to on github. The documentation says you can setup permissions to only allow pull and not push. So I'll turn this around on you and ask you to show me why this won't work. JE _______________________________________________ Mailing list: https://launchpad.net/~openstack Post to : [email protected] Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp
