On 2007-09-02 01:52:58 -0400, Michel Salim wrote:
> Date: Sun, 2 Sep 2007 01:52:58 -0400
> From: Michel Salim <[EMAIL PROTECTED]>
> Subject: Re: [opensuse-packaging] Please criticise my spec file.
> To: Marcus Rueckert <[EMAIL PROTECTED]>
> Cc: Cristian Rodriguez <[EMAIL PROTECTED]>,
> opensuse-packaging@opensuse.org
> X-DSPAM-Result: Whitelisted
> X-DSPAM-Confidence: 0.9905
> X-DSPAM-Probability: 0.0000
>
> On 01/09/07, Marcus Rueckert <[EMAIL PROTECTED]> wrote:
> > On 2007-09-01 22:38:55 -0400, Michel Salim wrote:
> > > On 01/09/07, Cristian Rodriguez <[EMAIL PROTECTED]> wrote:
> > > > Paul Elliott escribió:
> > > >
> > > > > -------------------cut here with a chainsaw--------------------
> > > > > # norootforbuild
> > > > > %define _prefix /opt/gnome
> > > >
> > > >
> > > > uh ho. GNOME has moved to /usr
> > > >
> > > %if %{?suse_version}
> > > %if %{suse_version} <= 1020
> > > %define _prefix /opt/gnome
> > > %endif
> > > %endif
> > >
> > > should do nicely.
> >
> > %if 0%{?suse_version} < 1030
> > %define _prefix /opt/gnome
> > %endif
>
> This will make the spec openSUSE-specific: if suse_version is not
> defined, you'll get
>
> %if 0 < 1030
>
> which will be bad if the spec is used to build packages for, say,
> Fedora or Mandriva as well. the %if %suse_version will guard against
> that, so _prefix is only overridden if
> 1. we are on openSUSE
> 2. it is a release < 10.3
>
> <= 1020 could be replaced with < 1030, both are OK since I believe no
> SUSE release has suse_version set to anything between 1020 and 1030.
>
so lets take
%if ! 0%{?suse_version} > 1020
darix
--
openSUSE - SUSE Linux is my linux
openSUSE is good for you
www.opensuse.org
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
