Yes, this issue came up before in ww 1.x tags ( Just check some of the tag's cvs log history ). Using release() to reset state between invocation is definitely inappropriate. I think using doFinally() should be the safest approach here. Not sure about the performance hit though.
--- Rick Salsa <[EMAIL PROTECTED]> wrote: > I just noticed that Matt made a number of changes to the ww2 tags, > primarily implementing the release method to reset state. Is there any > particular reason for doing this? > > If we want to reset those values, release is not the best place for it. > Here are some points for the Jakarta taglibs site: > > - release() is not necessarily called between invocations, which means that > tag logic should not count on private invocation- specific state being > reset by release() > > - release() *is* always called at least once for a tag handler before it is > garbage-collected, so this method can and should be used to release any > long-term resources > > We should be doing this in doStartTag: > > - Private state that's kept for each invocation should typically be reset > in doStartTag(), not in release(). If you have an iteration index > controlling the behavior of a loop, doStartTag() is the appropriate method > from which to initialize it. > > The above points can be found here: > http://jakarta.apache.org/taglibs/guidelines.html > > If there is something I'm missing, please let me know. I believe this came > up before with the ww 1.x tags, but I haven't been able to find it in the > archives yet. > > rick > > > > > ------------------------------------------------------- > This SF.net email is sponsored by: > The Definitive IT and Networking Event. Be There! > NetWorld+Interop Las Vegas 2003 -- Register today! > http://ads.sourceforge.net/cgi-bin/redirect.pl?keyn0001en > _______________________________________________ > Opensymphony-webwork mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork __________________________________________________ Do you Yahoo!? Yahoo! Platinum - Watch CBS' NCAA March Madness, live on your desktop! http://platinum.yahoo.com ------------------------------------------------------- This SF.net email is sponsored by: The Definitive IT and Networking Event. Be There! NetWorld+Interop Las Vegas 2003 -- Register today! http://ads.sourceforge.net/cgi-bin/redirect.pl?keyn0001en _______________________________________________ Opensymphony-webwork mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork
