I've made the changes to the code and as yet have not checked them in as there's something odd going on with the BeanTag. Once I figure out what the issue with BeanTag is, I'll check in the changes. As it turns out, the only reasonable place to put a reset() method is in the doEndTag. Because attributes are set before doStartTag() is called, doStartTag() isn't an appropriate place to reset the state of the Tag.

Here's a useful link that describes the lifecycle of a Taglib.

http://java.sun.com/j2ee/1.4/docs/tutorial/doc/JSPTags7.html#66976

Cheers!

Matt

Rick Salsa wrote:

I just noticed that Matt made a number of changes to the ww2 tags,
primarily implementing the release method to reset state. Is there any
particular reason for doing this?

If we want to reset those values, release is not the best place for it.
Here are some points for the Jakarta taglibs site:

- release() is not necessarily called between invocations, which means that
tag logic should not count on private invocation- specific state being
reset by release()

- release() *is* always called at least once for a tag handler before it is
garbage-collected, so this method can and should be used to release any
long-term resources

We should be doing this in doStartTag:

-  Private state that's kept for each invocation should typically be reset
in doStartTag(), not in release(). If you have an iteration index
controlling the behavior of a loop, doStartTag() is the appropriate method
from which to initialize it.

The above points  can be found here:
http://jakarta.apache.org/taglibs/guidelines.html

If there is something I'm missing, please let me know. I believe this came
up before with the ww 1.x tags, but I haven't been able to find it in the
archives yet.

rick




-------------------------------------------------------
This SF.net email is sponsored by:
The Definitive IT and Networking Event. Be There!
NetWorld+Interop Las Vegas 2003 -- Register today!
http://ads.sourceforge.net/cgi-bin/redirect.pl?keyn0001en
_______________________________________________
Opensymphony-webwork mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork






-------------------------------------------------------
This SF.net email is sponsored by:
The Definitive IT and Networking Event. Be There!
NetWorld+Interop Las Vegas 2003 -- Register today!
http://ads.sourceforge.net/cgi-bin/redirect.pl?keyn0001en
_______________________________________________
Opensymphony-webwork mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork

Reply via email to