OK - here I go (uh oh :)) I'm still thinking about all this - but here's my current thoughts:
1. The interface has not been removed yet. It's only in my local repository on my laptop. 2. The interface is still there - Action - however the _code_ does not use it anymore, it uses Object. 3. execute() is just a default method and actually nothing to do with Action. I think we should remove it from the Action interface as it is misleading now that you can run any method as your execute. Execute() is a best practice, not a necessity? That leads me to an interesting conundrum - the interface is not needed by _xwork_ however it's nice to have because OO tells us we should say 'this class IS AN action'. IMHO the solution to this is to leave the interface in the code, and anyone who cares about this can use it. XWork itself will just run methods on objects which are commands. If you want to 'flag' your POJO as an action, you are free to implement Action which is still in the codebase. Thoughts? M On 3/7/03 4:26 AM, "Hani Suleiman" ([EMAIL PROTECTED]) penned the words: > Yeah I know, I debated it with Mike yesterday, and I do see that that > it's easy to remove etc, but I just don't like using reflection for yet > another thing. Sure it's much faster that it used to be, but it's still > slower than a direct method call, so the gain to me is twofold, getting > rid of an unnecessarily slow invocation (reflection) as well as adding > an explicit contract. > > On Wednesday, July 2, 2003, at 02:16 PM, Jason Carreira wrote: > >> This is a concern that Mike expressed as well, but I challenged him to >> look at the code and see if it really makes sense. He looked, and >> grudgingly agreed that it made sense to get rid of it, especially since >> it took like 10 minutes and Gavin from Hibernate was there, talking >> about how he'd removed the Peristable interface from Hibernate because >> it was just useless. >> >> Giving people a warm fuzzy feeling is not enough justification, IMO, to >> needlessly tie Actions to Xwork, when they can really just be POJO's >> with no-arg methods returning a String. >> >> Jason >> >>> -----Original Message----- >>> From: Hani Suleiman [mailto:[EMAIL PROTECTED] >>> Sent: Wednesday, July 02, 2003 12:01 PM >>> To: [EMAIL PROTECTED] >>> Subject: Re: [OS-webwork] WebWork2, here I come! >>> >>> >>> I agree completely. All this 'just define it/figure it out at >>> runtime' >>> stuff really bothers me. Interfaces might be very 'old >>> school' now, but >>> they are useful, just so you know at compile time what >>> contracts your >>> components/classes/whatever are adhering to. I still have yet >>> to look >>> at xwork (waiting for migration guides+tools and performance >>> reports), >>> but the concept of having all information in an xml file and >>> an active >>> effort to remove type safety/contracts from code feels very wrong. I >>> understand the allure of 'but you can use ANYTHING as an >>> action!', but >>> I do feel that those things that are used as an action should >>> anticipate somewhat that they are one and will be treated as one, in >>> most cases. >>> >> >> >> ------------------------------------------------------- >> This SF.Net email sponsored by: Free pre-built ASP.NET sites including >> Data Reports, E-commerce, Portals, and Forums are available now. >> Download today and enter to win an XBOX or Visual Studio .NET. >> http://aspnet.click-url.com/go/psa00100006ave/direct;at.asp_061203_01/ >> 01 >> _______________________________________________ >> Opensymphony-webwork mailing list >> [EMAIL PROTECTED] >> https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork >> > > > > ------------------------------------------------------- > This SF.Net email sponsored by: Free pre-built ASP.NET sites including > Data Reports, E-commerce, Portals, and Forums are available now. > Download today and enter to win an XBOX or Visual Studio .NET. > http://aspnet.click-url.com/go/psa00100006ave/direct;at.asp_061203_01/01 > _______________________________________________ > Opensymphony-webwork mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork ------------------------------------------------------- This SF.Net email sponsored by: Free pre-built ASP.NET sites including Data Reports, E-commerce, Portals, and Forums are available now. Download today and enter to win an XBOX or Visual Studio .NET. http://aspnet.click-url.com/go/psa00100006ave/direct;at.asp_061203_01/01 _______________________________________________ Opensymphony-webwork mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork
